Update docs on std::out_of_range exception mapping #1254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs currently says that `std::out_of_range` is mapped to `ValueError`, but source says `IndexError`. Given the documentation for `std::out_of_range` it seems like `IndexError` is the correct one, so the docs should be updated.
|
Seconded. |
19 tasks
wjakob
added a commit
that referenced
this pull request
Jun 11, 2019
|
Merged (I did so directly from my account due to conflicts, and since it was just a 1-line change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs currently says that
std::out_of_rangeis mapped toValueError, but source saysIndexError.Given the documentation for
std::out_of_rangeit seems likeIndexErroris the correct one, so the docs should be updated.