Skip to content

ci: GHA basic format & pre-commit #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2020
Merged

ci: GHA basic format & pre-commit #2309

merged 1 commit into from
Jul 20, 2020

Conversation

henryiii
Copy link
Collaborator

Implementing basic GHA formatting. Changes:

  • Pre-commit support. All checks except for C++ format (to be added later) are available in pre-commit instead of custom tools/check_style.sh - also checks flake8. Many of the old warnings are now automatic fixes.
  • GitHub Actions checks pre-commit style
  • Flake8: Added bugbear - manually fixed a few resulting "unused variable" warnings
  • pre-commit: Added encoding & whitespace fixes to several files automatically

I added tab -> 4 space automatic conversion, but there's also a mode that simply errors on any tabs. You always get to review changes with pre-commit before adding them in git, so automatic is usually better, but we could use the other mode for tabs.

@henryiii henryiii merged commit d8c7ee0 into master Jul 20, 2020
@henryiii henryiii deleted the ci/gha branch July 20, 2020 17:35
@henryiii henryiii added the ci related to the CI system label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant