Skip to content

docs: fix pdf build #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2020
Merged

docs: fix pdf build #2736

merged 1 commit into from
Dec 22, 2020

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Dec 22, 2020

Description

Docs are currently broken when generating the PDF. This fixes it and updates
the doc build a bit.

This is fixed by removing the header of the README (the svg to PDF on the second line of badges was broken - didn't seem to matter what badges were there, just having the second line broke it. Badges aren't useful in a PDF anyway, so dropped them.

Suggested changelog entry:

None needed, docs fix for breaking after 2.6.1.

@henryiii henryiii changed the title docs: fix pdf build, simpler start page docs: fix pdf build Dec 22, 2020
@henryiii henryiii added this to the v2.6.2 milestone Dec 22, 2020
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! (Took me a while to see that "removing the header of the README" isn't literal; nice trick with the .. start.)

@henryiii henryiii merged commit 79b0e2c into pybind:master Dec 22, 2020
@henryiii henryiii deleted the fix/docpdf branch December 22, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants