fix: add null pointer check with std::localtime #2846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/pybind11/chrono.h
Outdated
| // (https://en.cppreference.com/w/cpp/chrono/c/localtime) | ||
| std::tm *localtime_ptr = std::localtime(&tt); | ||
| if (!localtime_ptr) | ||
| pybind11_fail("pybind11::chrono: Unable to represent system_clock in local time"); |
There was a problem hiding this comment.
pybind11_fail is meant for internal errors, so this is not correct. Maybe throw py::cast_error? Maybe have a look at what other casters do, please.
There was a problem hiding this comment.
If the CI wants to turn green, this seems better, indeed. Thanks! :-)
There was a problem hiding this comment.
I am not sure what broke in test_recarray in test_numpy_dtypes.py on CentOS 7. I will try debugging it, now that it has failed twice.
There was a problem hiding this comment.
Very weird that it would be related, though
There was a problem hiding this comment.
It's not, it's started breaking everywhere.
knzivid
force-pushed
the
localtime-nullptr-check
branch
from
bb1628b to
438c6dd
Compare
YannickJadoul
approved these changes
Feb 4, 2021
|
Please don't remove the changelog part of the template, we use that to generate the changelog. Otherwise, fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related conversation https://gitter.im/pybind/Lobby?at=601be2a61ed88c58d81d719a
Suggested changelog entry:
* Add null pointer check with ``std::localtime``.