Skip to content

setup_helpers: try import multiprocessing.synchronize too #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

jbarlow83
Copy link
Contributor

@jbarlow83 jbarlow83 commented Jun 17, 2021

Description

Some "exotic" platforms like AWS Lambda and Android Termux can fork processes but cannot create semaphores due to not have /dev/shm or something of that nature. On these platforms the current setup_helpers test will pass, but parallel compilation will fail. This simple change makes the test more comprehensive.

Suggested changelog entry:

In ``setup_helpers.py``, test for platforms that have some multiprocessing features but lack semaphores, which ``ParallelCompile`` requires.

@jbarlow83 jbarlow83 requested a review from henryiii as a code owner June 17, 2021 07:56
@henryiii henryiii merged commit 79178e7 into pybind:master Jun 18, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 18, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants