Skip to content

add tests for boost::optional casters #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Oct 6, 2021

Description

  • Adds tests for boost::optional casters to test suite as well.

Suggested changelog entry:

* Adds tests for boost::optional when compiling pre-C++17 tests.

@Skylion007 Skylion007 requested review from rwgk and henryiii October 6, 2021 14:57
@Skylion007 Skylion007 changed the title (bugfix): Fix STL optional casting issue fix: Fix STL optional casting issue Oct 6, 2021
@Skylion007 Skylion007 closed this Oct 6, 2021
@Skylion007 Skylion007 reopened this Oct 8, 2021
@Skylion007 Skylion007 closed this Oct 8, 2021
@Skylion007 Skylion007 reopened this Oct 8, 2021
@Skylion007
Copy link
Collaborator Author

@ryancahoon-zoox something like this (although I am running into a bit of trouble backporting nullopt at the moment).

@Skylion007 Skylion007 changed the title fix: Fix STL optional casting issue add tests for boost::optional casters Oct 11, 2021
@henryiii
Copy link
Collaborator

I think this was included in #3376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants