-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Adding dedicated test_const_name. #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also exercises pybind11::detail::_ backward compatibility. See also: PR pybind#3423
tests/test_const_name.py
Outdated
|
||
@pytest.mark.parametrize( | ||
"func, selector_expected", | ||
itertools.product( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you parameterize func
, and selector_expected
separately, it will implicitly do an itertools.product between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks!
Thank you for the reviews! |
Gg |
Description
Also exercises
pybind11::detail::_
backward compatibility.See also: PR #3423
Notes:
pybind11::detail::_
is sufficiently exercised on the many other platforms._<0>()
and similar only works with C++17 or higher (source code comment added). This functionality is not actually used, therefore the corresponding tests were backed out.An easy way to disable backward compatibility is to patch include/pybind11/detail/descr.h like this:
Suggested changelog entry: