Skip to content

EXPERIMENTAL: clang-format on top of pending PR #3702 #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 9, 2022

Helper/scratch PR for testing.

Some comments are probably in bad shape, especially rst-endrst.

The purpose of this PR is to see if the reformatted C++ code works on all platforms.

Game plan from here:

After the mutually independent PRs

are merged:

  • Prepare source code comments for clang-formating (this will be a bit of time-consuming leg work).
  • Main clang-format PR (pre-commit action & automatic large-scale changes).
  • Add IncludeCategories to .clang-format (9057962).
  • Done! (Unless I'm forgetting something.)

@rwgk rwgk force-pushed the clang-format_N+1 branch from a1b18ea to 63271f5 Compare February 9, 2022 01:59
@rwgk rwgk force-pushed the clang-format_N+1 branch from ae49e5e to 9eec9f5 Compare February 9, 2022 02:18
@rwgk
Copy link
Collaborator Author

rwgk commented Feb 9, 2022

Closing this PR, it served its purpose, testing with PRs #3702, #3704, #3705 combined, and laying out the game plan in the PR description. This documents a small milestone on the way to full clang-formating.

@rwgk rwgk closed this Feb 9, 2022
@rwgk rwgk deleted the clang-format_N+1 branch February 9, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants