Avoid catch (...) for expected import numpy failures
#3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
May 26, 2022
|
Can we restrict any usage of |
Skylion007
approved these changes
May 26, 2022
@henryiii Unfortunately, no. We need to use it for exception translators / exception handling so at least need to be present there. We also need it for noexcept handling as well. Finally, I am not aware of clang-tidy rules or such to restrict this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from PR #3964, where the
catch (...)happened to cause significant confusion because they are silently dropping any kind of error. This is likely to cause more confusion in future development work. Narrowing down tocatch (const py::error_already_set &)is a simple way to significantly reduce the potential for silently dropping important errors (although that is still not perfect).Suggested changelog entry: