Skip to content

chore: Add pytests for constructing pytypes from iterable #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2022
Merged

chore: Add pytests for constructing pytypes from iterable #4138

merged 6 commits into from
Aug 11, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • I was going through the code and wanted to add some tests for the iterable to pytype ctors since I noticed are unit tests for the iterable class are working. Since I wrote the tests to verify this use case worked properly, I thought I might as well commit them.

@Skylion007 Skylion007 requested review from rwgk and henryiii August 11, 2022 18:15
@Skylion007 Skylion007 marked this pull request as ready for review August 11, 2022 18:15
rwgk
rwgk approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Skylion007 Skylion007 merged commit b884b9d into pybind:master Aug 11, 2022
@Skylion007 Skylion007 deleted the skylion007/extra-iterable-tests branch August 11, 2022 20:14
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 11, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii