chore: future safe bugbear opinionated warnings #4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
rwgk
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Thank you!
What made this particularly confusing: I first saw B905 only on my local workstation, but not in GHA, then suddenly in some GHA jobs but not others, only eventually everywhere. — I'm guessing it was some rollout window that overlapped with what I was doing.
Skylion007
approved these changes
Dec 10, 2022
|
There’s quite a bit of caching with pre-commit, that’s why it’s so fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future safe version of #4391. I've been applying this fix elsewhere.
The opinionated checks are not something you can just enable anymore, after B905 shows that non-EoL Pythons can be required for them. Instead, just turn on the ones that are helpful, and if more are added in the future, we can add them if we like them.