Skip to content

bugfix: delete proper ctors in gil.h #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2023
Merged

bugfix: delete proper ctors in gil.h #4490

merged 1 commit into from
Feb 4, 2023

Conversation

Skylion007
Copy link
Collaborator

Description

Fix #4484 . A copy paste bug resulted in a non-existent ctor being deleted.

Suggested changelog entry:

* bugfix: ensure gil_scoped_release RAII is non-copyable.

@Skylion007 Skylion007 requested review from rwgk and henryiii February 4, 2023 15:40
@Skylion007 Skylion007 force-pushed the skylion007/fix-gil-deleted-ctor-bug branch from e9693fd to a24fea0 Compare February 4, 2023 15:43
rwgk
rwgk approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow, how did you notice?

(I would have guessed the current code doesn't even compile TBH; or at least clang-tidy will get upset. I'll look more carefully in the future.)

@Skylion007 Skylion007 changed the title bugfix: delete proper ctor in gil.h bugfix: delete proper ctors in gil.h Feb 4, 2023
@Skylion007 Skylion007 merged commit 08a89fa into pybind:master Feb 4, 2023
@Skylion007 Skylion007 deleted the skylion007/fix-gil-deleted-ctor-bug branch February 4, 2023 18:40
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 4, 2023
@Skylion007
Copy link
Collaborator Author

Skylion007 commented Feb 4, 2023 •
edited
Loading

@rwgk I didn't. The author of #4484 noticed.

@rwgk rwgk mentioned this pull request Feb 11, 2023
Closed
henryiii pushed a commit that referenced this pull request Feb 24, 2023
@Skylion007 @henryiii
bugfix: delete proper ctors in gil.h (#4490)
a491af6
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Wrong argument for gil_scoped_release deleted copy constructor
3 participants
@Skylion007 @rwgk @henryiii