Skip to content

Provide PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF as an option #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 17, 2023
Merged

Provide PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF as an option #4753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a29da71
Remove GIL checks
EthanSteinberg Jul 16, 2023
6f9546a
Update common.h
EthanSteinberg Jul 16, 2023
bd4b39f
Add flag
EthanSteinberg Jul 16, 2023
3cd9589
style: pre-commit fixes
pre-commit-ci[bot] Jul 16, 2023
3b1a4e5
Update pytypes.h
EthanSteinberg Jul 16, 2023
7e41bf2
style: pre-commit fixes
pre-commit-ci[bot] Jul 16, 2023
f67e2ac
Update common.h
EthanSteinberg Jul 16, 2023
6b79e5a
style: pre-commit fixes
pre-commit-ci[bot] Jul 16, 2023
f06c975
Update pytypes.h
EthanSteinberg Jul 16, 2023
253c1fe
style: pre-commit fixes
pre-commit-ci[bot] Jul 16, 2023
961eb6c
Update common.h
EthanSteinberg Jul 16, 2023
28e6fa2
style: pre-commit fixes
pre-commit-ci[bot] Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/pybind11/detail/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ PYBIND11_WARNING_POP
#endif

// See description of PR #4246:
#if !defined(NDEBUG) && !defined(PY_ASSERT_GIL_HELD_INCREF_DECREF) && !defined(PYPY_VERSION) \
&& !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF)
#if !defined(PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF) && !defined(NDEBUG) \
&& !defined(PYPY_VERSION) && !defined(PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF)
# define PYBIND11_ASSERT_GIL_HELD_INCREF_DECREF
#endif

Expand Down
7 changes: 6 additions & 1 deletion include/pybind11/pytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,12 @@ class handle : public detail::object_api<handle> {
stderr,
"%s is being called while the GIL is either not held or invalid. Please see "
"https://pybind11.readthedocs.io/en/stable/advanced/"
"misc.html#common-sources-of-global-interpreter-lock-errors for debugging advice.\n",
"misc.html#common-sources-of-global-interpreter-lock-errors for debugging advice.\n"
"If you are convinced there is no bug in your code, you can #define "
"PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF"
"to disable this check. In that case you have to ensure this #define is consistently "
"used for all translation units linked into a given pybind11 extension, otherwise "
"there will be ODR violations.",
function_name.c_str());
fflush(stderr);
if (Py_TYPE(m_ptr)->tp_name != nullptr) {
Expand Down