fix: define _DEBUG macro to 1 on redefinition
#5639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the msvc documentation, the macro should be defined to 1: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros
henryiii
approved these changes
May 7, 2025
henryiii
changed the title
_DEBUG macro to 1 on redefinition_DEBUG macro to 1 on redefinition
b-pass
pushed a commit
to b-pass/pybind11
that referenced
this pull request
May 9, 2025
According to the msvc documentation, the macro should be defined to 1: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
_DEBUGmacro is currently defined without value on redefinition. According to the msvc documentation, the macro should be defined to1.Suggested changelog entry: