Skip to content

Use define_macros for macros #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use define_macros for macros #39

wants to merge 3 commits into from

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Feb 20, 2019

Moves VERSION_INFO to define_macros
Copies stdlib flag to link time as well.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 21, 2019

Ready for review.

@isuruf
Copy link
Contributor Author

isuruf commented Feb 28, 2019

Ping

@wjakob
Copy link
Member

wjakob commented Jun 25, 2019

Apologies for the long delay. This PR seems to be somewhat garbled relative to 'master' -- could you rebase it? Also, it would be great to have some summary of why you are making those changes? (it wasn't immediately clear to me.)

@wjakob wjakob force-pushed the master branch 2 times, most recently from fe696bc to 08a2f37 Compare June 25, 2019 14:50
@isuruf
Copy link
Contributor Author

isuruf commented Apr 9, 2020

This is ready for review now

@isuruf isuruf changed the title Use proper options for flags Use define_macros for macros Apr 9, 2020
wjakob added a commit that referenced this pull request Apr 26, 2020
@wjakob
Copy link
Member

wjakob commented Apr 26, 2020

This looks good. GitHub wasn't willing to merge this PR due to conflicts, so I just did so directly.

@wjakob wjakob closed this Apr 26, 2020
@isuruf
Copy link
Contributor Author

isuruf commented Apr 26, 2020

Thanks

@isuruf isuruf deleted the flags branch April 26, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants