Skip to content

Fix IncEx type alias to be compatible with mypy #10813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 11, 2024

Change Summary

Requires pydantic/pydantic-core#1537

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 11, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6198d35
Status: ✅  Deploy successful!
Preview URL: https://b087083e.pydantic-docs.pages.dev
Branch Preview URL: https://inc-ex-ann-3.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #10813 will not alter performance

Comparing inc-ex-ann-3 (6198d35) with main (4eecee7)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

Happy to merge tomorrow once we get that pydantic-core release out.

@sydney-runkle sydney-runkle added the deferred Deferred until future release or until something else gets done label Nov 11, 2024
@sydney-runkle sydney-runkle enabled auto-merge (squash) November 12, 2024 19:17
@sydney-runkle sydney-runkle removed the deferred Deferred until future release or until something else gets done label Nov 12, 2024
@sydney-runkle sydney-runkle merged commit 8bad227 into main Nov 12, 2024
52 checks passed
@sydney-runkle sydney-runkle deleted the inc-ex-ann-3 branch November 12, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants