Skip to content

Add additional allowed schemes for ClickHouseDsn #11319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

Maze21127
Copy link
Contributor

@Maze21127 Maze21127 commented Jan 22, 2025

Change Summary

allowed_schemes in ClickHouseDsn don't compability with base clickhouse schema, this PR fix it

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 22, 2025
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #11319 will not alter performance

Comparing Maze21127:clickhousedsn-chemas (c56d6bd) with main (221275f)

Summary

✅ 45 untouched benchmarks

@Maze21127
Copy link
Contributor Author

please review

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos changed the title Add additional allowed schemas for ClickHouseDsn Add additional allowed schemes for ClickHouseDsn Jan 23, 2025
@Viicos
Copy link
Member

Viicos commented Jan 23, 2025

Could you please provide info attesting that clickhouses/clickhousedb are valid schemes?

@Maze21127
Copy link
Contributor Author

Could you please provide info attesting that clickhouses/clickhousedb are valid schemes?

clickhouses - secure connection in clickhouse-driver

clickhousedb - uses in clickhouse-connect

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Viicos Viicos enabled auto-merge (squash) January 24, 2025 10:49
@Viicos Viicos disabled auto-merge January 24, 2025 10:49
@Viicos Viicos enabled auto-merge (squash) January 24, 2025 10:49
@Viicos Viicos merged commit 192845d into pydantic:main Jan 24, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants