Skip to content

Fix NotRequired qualifier not taken into account in stringified annotation #11559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 14, 2025

Also update docstring of the relevant GenerateSchema method.

Regression in #11479.

Fixes #11557, fixes pydantic/pydantic-ai#1143.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Mar 14, 2025
…otation

Also update docstring of the relevant `GenerateSchema` method.
Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5970ea2
Status: ✅  Deploy successful!
Preview URL: https://94f84c7b.pydantic-docs.pages.dev
Branch Preview URL: https://td-notrequired.pydantic-docs.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Mar 14, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link

codspeed-hq bot commented Mar 14, 2025

CodSpeed Performance Report

Merging #11559 will not alter performance

Comparing td-notrequired (5970ea2) with main (b9fb3f1)

Summary

✅ 46 untouched benchmarks

@Viicos Viicos merged commit d85f511 into main Mar 17, 2025
62 checks passed
@Viicos Viicos deleted the td-notrequired branch March 17, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation errors for _GeminiResponse __future__ annotations + TypedDict NotRequired broken in 2.11.0b1
2 participants