Skip to content

Code cleanup (unused imports, unused variables...) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
femtotrader opened this issue Nov 16, 2015 · 3 comments
Closed

Code cleanup (unused imports, unused variables...) #119

femtotrader opened this issue Nov 16, 2015 · 3 comments
Milestone
0.3.0

Comments

@femtotrader
Copy link
Contributor

Hello,

according to
https://landscape.io/github/pydata/pandas-datareader/
there is 2 "errors" (same line 75 in wb.py)

def download(country=['MX', 'CA', 'US'], indicator=['NY.GDP.MKTP.CD', 'NY.GNS.ICTR.ZS'], ...)

these 2 errors are

Dangerous default value [] as argument

There is also some "smells" and some "Style" issues.

Badge Code Health

can be inserted with the following reStructuredText code

.. image:: https://landscape.io/github/pydata/pandas-datareader/master/landscape.svg?style=flat
   :target: https://landscape.io/github/pydata/pandas-datareader/master
   :alt: Code Health

Kind regards
@femtotrader femtotrader changed the title Dangerous default value [] as argument Code cleanup (Dangerous default value [], unused imports, unused variables...) Nov 16, 2015
@femtotrader femtotrader changed the title Code cleanup (Dangerous default value [], unused imports, unused variables...) Code cleanup (Dangerous default value [] error, unused imports, unused variables...) Nov 16, 2015
@sinhrks sinhrks mentioned this issue Nov 22, 2015
Merged
@femtotrader femtotrader mentioned this issue Nov 25, 2015
Merged
@femtotrader femtotrader changed the title Code cleanup (Dangerous default value [] error, unused imports, unused variables...) Code cleanup (unused imports, unused variables...) Nov 25, 2015
@femtotrader
Copy link
Contributor Author 

Dangerous default value [] error

is fixed by http://github.com/pydata/pandas-datareader/pull/121

but some cleanup is still possible

@davidastephens davidastephens added this to the 0.3.0 milestone Dec 6, 2015
@femtotrader
Copy link
Contributor Author

It may be a good idea to add flake8 to .travis.yml

@femtotrader
Copy link
Contributor Author

PR #162 being merged we can probably close this issue now.

@femtotrader femtotrader mentioned this issue Jan 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@femtotrader @davidastephens