Skip to content

Add PEP8 with flake8 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2016
Merged

Add PEP8 with flake8 #162

merged 1 commit into from
Jan 30, 2016

Conversation

femtotrader
Copy link
Contributor

This PR enables flake8 with Travis and should help code cleanup #119

@femtotrader
Copy link
Contributor Author

@davidastephens

it will be great if this PR could be merged before other ones as a lot of files have been (very slightly) modified.

@bashtage
Copy link
Contributor

These types of cleanups tend to break any other PRs, so I would suggest getting any ready or nearly ready PRs in first and the reading this before merging.

@jtkiley
Copy link
Contributor

jtkiley commented Jan 29, 2016

#159 is ready to go, and I use flake8, so it should play nice with this PR.

@femtotrader: Nice work. I was thinking about this, and I'll be really happy to see that green check mark in Atom.

davidastephens added a commit that referenced this pull request Jan 30, 2016
@davidastephens davidastephens merged commit 823e6fc into pydata:master Jan 30, 2016
@femtotrader
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants