ENH: Add support for Nasdaq symbol list #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2016 17:46
Nasdaq provides a symbol list with all US equities, listed on the Nasdaq and other exchanges on their FTP site. This patch adds support for grabbing that list. The list isn't very larger (< 1 MB), so we cache it to RAM within the process the first time we download it.
robottwo
changed the title
|
Thanks @robottwo for this contribution. There is unit tests, documentation. I'm ok for merging but I will wait about one week before doing this to allow other people to give their feedback about this PR. Thanks again |
|
Thanks again @robottwo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nasdaq provides a symbol list with all US equities,
listed on the Nasdaq and other exchanges on their
FTP site. This patch adds support for grabbing
that list.
The list isn't very larger (< 1 MB), so we cache it
to RAM within the process the first time we download it.