-
Notifications
You must be signed in to change notification settings - Fork 679
IEX Implementation #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEX Implementation #308
Conversation
tests would be nice |
Added some test cases |
394e311
to
fcad296
Compare
Rebased for some of gfyoung's recent fixes and cleaned up the formatting. |
Rebased on 0.4.0 and implemented the newly launched DEEP API. Support implemented for:
All associated documentation is linked above. Noting that Travis failed due to Yahoo's iCharts API currently being down. Can a maintainer please restart the build when we have confirmation that it is back up? Thank you! |
your tests are failing because of importing:
timezone is not a module. you can use pytz directly, or simply use pandas timezone manip (which is vectorized). |
Ah, thank you. Non-Yahoo tests are passing now. |
@@ -56,6 +66,42 @@ def get_quote_google(*args, **kwargs): | |||
return GoogleQuotesReader(*args, **kwargs).read() | |||
|
|||
|
|||
def get_tops_iex(*args, **kwargs): | |||
return IEXTops(*args, **kwargs).read() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prob do these inside each function this is odd to import everything (though that's the existing style)
e.g.
def get_tops_iex(....):
from pandas_datareader.iex.tops import TopsReader
return TopsReader(....)
further would be nice to have a docstring here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, no need to pollute the namespace further even for consistency's sake. Pushed an update with this change and docstrings, but I left imports in for the functions implemented by DataReader.
can you rebase |
… after market hours
@rgkimball Looks great - can you please rebase and add some docs, then we can merge. |
Can you rebase on master so we can see if things pass. |
IEX recently announced the first version of a free market data API used to access a wide variety of data useful for traders, consisting of:
This pull request implements all of the services available in their initial launch, except for the live prices via socket, and makes them available in DataFrames via pandas_datareader. Note that the API will return None for weekends and market holidays, and reports a special field for half days. Some examples:
In the coming months, IEX also plans to implement: