added QuandlReader (plus tests and doc) #346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding Yahoo Finance: For the time being, I suggest to deactivate the tests, put a remark into the docs, but leave the code in place (and remove it in a year or so). |
|
can you rebase |
This was referenced Jul 5, 2017
|
superseded by #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reasonably nice Quandl adapter (more needed now that the Yahoo Finance daily data API has gone down).
Because of the Yahoo breakdown, the tests currently do not run.
Also, I am on Windows, where the Google tests will be skipped.
But I have probably not broken anything; I've limited my changes to existing parts to the minimum.
Note: One should refactor the url/_get_params construction for BaseReader: The format of the URL belongs under the complete control of the implementing class. For Quandl this is needed because the DB name is part of the base URL, not the parameters. My current construction is a bit of a kludge in this respect.