Skip to content

fix theme elements page #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix theme elements page #1356

merged 1 commit into from
Jun 22, 2023

Conversation

drammock
Copy link
Collaborator

@drammock drammock commented Jun 20, 2023 •
edited
Loading

closes #1355

thanks @QuLogic for reporting

@drammock
Copy link
Collaborator Author

CIs are all green; ready for review. Here's the relevant part of the changed page: https://pydata-sphinx-theme--1356.org.readthedocs.build/en/1356/user_guide/theme-elements.html#admonition-sidebars

The sections Admonition sidebars and Footnotes are the ones that have changes.

12rambau
12rambau approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@12rambau 12rambau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, nice catch.

@drammock drammock merged commit bc82874 into pydata:main Jun 22, 2023
@drammock drammock deleted the fix-theme-elements-page branch June 22, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12rambau 12rambau 12rambau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

section order error on theme-elements page
2 participants
@drammock @12rambau