Skip to content

docs: add the link to the transifex project #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Feb 5, 2024

I realized in #1697 that the translation project is not linked anywhere on the frontpage. The i18n updates must come from this platform only as it's also maintaining the header of the .po files.

It's not perfect but that's a patch prior to revamp the i18n interface and upload process.

Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @12rambau 🙌🏽

Seeing this made me have a look at our translation/localisation docs https://pydata-sphinx-theme.readthedocs.io/en/stable/community/topics/i18n.html which seem to be out of date now, is that correct or am I missing something?

If so I can open an issue to update them

@trallard trallard added the kind: documentation Improvements or additions to documentation label Feb 5, 2024
@12rambau
Copy link
Collaborator Author

12rambau commented Feb 5, 2024

it's correct, to update them you can try to follow the instructions of the documentation. I'm not 100% sure it's still working but we'll check the files carrefuly in the PR ;-)

Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merge after #1717 goes in and we re-trigger the CIs here (and they come back green)

@drammock
Copy link
Collaborator

this new CI failure should get fixed by #1751, so I think we're OK to merge here.

@drammock drammock merged commit 4a91790 into pydata:main Mar 29, 2024
ivanov pushed a commit to ivanov/pydata-sphinx-theme that referenced this pull request Jun 5, 2024
* docs: add the link to the transifex project

* retrigger CIs

---------

Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants