-
Notifications
You must be signed in to change notification settings - Fork 339
adding configuration page and a few options #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
html_theme_options = { | ||
"external_links": [ | ||
{ | ||
'url': "https://pandas.pydata.org/pandas-docs/stable/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also be a tuples of (name, url), but the dict is also good for me (and a dict is more easily extendable, if needed in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I suppose the dict is also nicer to use in the jinja layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I was thinking a dict because it'll be more obvious in the templates
|
||
i.fa-github-square:before { | ||
content: "\f092"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the font-awesome noob: what is this doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the unicode version of a fontawesome icon. FontAwesome is a standard icon pack that you can load via CDN and then use for icons on your site. The Bokeh docs are using fontawesome for their github / twitter logos so I figured we can just copy the same pattern here
I updated the fontawesome bits to use |
Decided to refresh myself on how to use variables in themes :-)
This does the following: