ENH: manage sidebars on small screens #726
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -141,7 +141,6 @@ | |
| } | ||
|
|
||
| html_sidebars = { | ||
| "contribute/index": [ | ||
| "sidebar-nav-bs", | ||
| "custom-template", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| .bd-header-article__inner { | ||
| min-height: var(--pst-header-article-height); | ||
| display: flex; | ||
| align-items: center; | ||
| padding: 0 0.5rem; | ||
|
|
||
| .bd-header-article__end { | ||
| margin-left: auto; | ||
| } | ||
|
|
||
| // We hide this at the secondary breakpoint because no buttons are present here | ||
| @include media-breakpoint-up($breakpoint-sidebar-secondary) { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| // Toggle labels | ||
| label { | ||
| &.sidebar-toggle { | ||
| display: flex; | ||
| cursor: pointer; | ||
| font-size: 1.2rem; | ||
| align-items: center; | ||
| color: var(--pst-color-muted); | ||
| } | ||
|
|
||
| // Flip the icon right-to-left on the left side | ||
| &.primary-toggle { | ||
| transform: scale(-1, 1); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,19 +2,21 @@ | |
| * The primary sidebar on the left. | ||
| * e.g., between-pages navigation. | ||
| */ | ||
|
|
||
| .bd-sidebar-primary { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| max-height: calc(100vh - var(--pst-header-height)); | ||
| position: sticky; | ||
| top: var(--pst-header-height); | ||
| @include make-col(3); | ||
|
|
||
| // Borders padding and whitespace | ||
| padding: 2rem 1rem 1rem 1rem; | ||
| border-right: 1px solid var(--pst-color-border); | ||
| background-color: var(--pst-color-background); | ||
| overflow-y: auto; | ||
|
|
||
| @include scrollbar-style(); | ||
|
|
||
|
|
@@ -40,14 +42,13 @@ | |
| } | ||
| } | ||
| } | ||
| // Navigation item chevrons | ||
| label { | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| height: 30px; | ||
| width: 30px; | ||
|
|
||
| cursor: pointer; | ||
|
|
||
|
|
@@ -86,6 +87,11 @@ | |
| /* Between-page links and captions */ | ||
| nav.bd-links { | ||
| font-size: var(--pst-sidebar-primary-font-size); | ||
| margin-right: -1rem; | ||
|
There was a problem hiding this comment. @12rambau do you remember why you styled I can plainly see and understand why you set the negative -1rem margin for the in-page TOC in the right sidebar (it's so that the vertical notch that indicates the current section is aligned properly), but so far I haven't been able to figure out what the -1rem margin is doing for the left sidebar. (On the left sidebar, the current section notches are not aligned to any vertical line.) There was a problem hiding this comment. the About the |
||
|
|
||
| @include media-breakpoint-up($breakpoint-sidebar-primary) { | ||
| display: block; | ||
| } | ||
|
|
||
| ul { | ||
| list-style: none; | ||
|
|
@@ -98,7 +104,7 @@ nav.bd-links { | |
|
|
||
| li > a { | ||
| display: block; | ||
| padding: 0.25rem 0; | ||
| color: var(--pst-color-text-muted); | ||
|
|
||
| &:hover { | ||
|
|
@@ -134,7 +140,6 @@ nav.bd-links { | |
| position: relative; | ||
| margin-top: 1.25em; | ||
| margin-bottom: 0.5em; | ||
| color: var(--pst-color-text-base); | ||
| &:first-child { | ||
| margin-top: 0; | ||
|
|
@@ -159,18 +164,6 @@ nav.bd-links { | |
| } | ||
| } | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
| // Togglable expand/collapse | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on this, but just a note that this will be a breaking change so we should note it in the release notes