Automatic Dask-Zarr chunk alignment #10336
Draft
+230
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still working on some details of this PR, but as it stands, it works and demonstrates an implementation that avoids breaking changes.
At this stage, my main concerns are:
Chunk Handling Utilities – It seems there are no utility functions for managing chunks, which results in possible duplicated code across the various backends. To address this, I created a class with several static methods, though I’m not convinced this is the best solution. I’m uncertain whether these functions should be placed in a separate file or incorporated into the existing
common.py
file for backends. Alternatively, should there be an external package that provides these chunk utilities? It’s possible the Dask team already has something similar implemented, but I haven't confirmed this yet.Backend Test Organization – The test file for backends has grown significantly in size, making it harder to manage. It might be beneficial to start adding new tests in a separate file to improve maintainability.
I’d appreciate any feedback or suggestions regarding these concerns!
whats-new.rst
api.rst