Skip to content

Apply assorted ruff/Pylint rules (PL) / Enforce PLE rules #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

PLC, PLR and PLW rules are often irrelevant. Enforce PLE rules only.

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

PLC0206 Extracting value from dictionary without calling `.items()`
PLR1714 Consider merging multiple comparison
PLR2044 Line with empty comment
PLR5501 Use `elif` instead of `else` then `if`, to reduce indentation
PLW0127 Self-assignment of variable

The intent of the "flake8 workaround" might have been to avoid F811 errors.
These F811 errors exist only because of the ignored F401 errors. So ignore
F401 errors more precisely to clarify the situation.
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 29, 2025 09:51
@max-sixty max-sixty merged commit 85deeac into pydata:main May 29, 2025
32 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PL branch May 29, 2025 20:16
dcherian added a commit to dcherian/xarray that referenced this pull request May 30, 2025
* main:
  Fix performance regression in interp from pydata#9881 (pydata#10370)
  html repr: improve style for dropdown sections (pydata#10354)
  Grouper tweaks. (pydata#10362)
  Docs: Add links to getting help mermaid diagram (pydata#10324)
  Enforce ruff/flynt rules (FLY) (pydata#10375)
  Add missing AbstractWritableDataStore base methods and arguments (pydata#10343)
  Improve html repr in dark mode (Jupyterlab + Xarray docs) (pydata#10353)
  Pin Mypy to 1.15 (pydata#10378)
  use numpy dtype exposed by zarr array instead of metadata.data_type (pydata#10348)
  Fix doc typo for caption "Interoperability" (pydata#10374)
  Implement cftime vectorization as discussed in PR pydata#8322 (pydata#8324)
  Enforce ruff/flake8-pyi rules (PYI) (pydata#10359)
  Apply assorted ruff/Pylint rules (PL) / Enforce PLE rules (pydata#10366)
  (fix): pandas extension array repr for int64[pyarrow] (pydata#10317)
  Enforce ruff/flake8-implicit-str-concat rules (ISC) (pydata#10368)
  Enforce ruff/refurb rules (FURB) (pydata#10367)
  Ignore ruff/Pyflakes rule F401 more precisely (pydata#10369)
  Apply assorted ruff/flake8-simplify rules (SIM) (pydata#10364)
  Apply assorted ruff/flake8-pytest-style rules (PT) (pydata#10363)
  Fix "a array" misspelling (pydata#10365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants