Skip to content

Add sphinx-gallery to the docs #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2017
Merged

Add sphinx-gallery to the docs #1419

merged 5 commits into from
May 24, 2017

Conversation

fmaussion
Copy link
Member

@fmaussion fmaussion commented May 21, 2017

This uses sphinx-gallery to illustrate some examples of the xarray workflow. See it rendered here

It's nicer for the gallery if there is a plot to draw in the end but it doesn't have to be a plot. Once the gallery gets more examples it's possible to sort them by topic (see the sphinx gallery documentation for an overview of the possibilities).

I could think of several other things we could add (including moving or copying @jhamman and @rabernat 's examples to the gallery), but I thought it's better to merge quickly in order to encourage the community to contribute with more examples before the next release.

@fmaussion fmaussion assigned fmaussion and unassigned fmaussion May 21, 2017
@shoyer
Copy link
Member

shoyer commented May 21, 2017

This looks great -- but maybe move the "Gallery" section under "Examples"?

@fmaussion
Copy link
Member Author

maybe move the "Gallery" section under "Examples"?

good idea: done.

@rabernat
Copy link
Contributor

rabernat commented May 23, 2017

Great idea to use sphinx-gallery. I agree that it's best to get the basic functionality working first. Then we can migrate the other examples to sphinx-gallery once we have a working template.

@shoyer
Copy link
Member

shoyer commented May 23, 2017

Thinking about this a little bit more -- maybe we would rather use something like nbsphinx that lets us directly embed ipython notebooks in the docs and/or write notes in the form of notebooks?

sphinx-gallery seems very well suited to an examples that produce a single plot but not much else. Maybe we should put this gallery on the "Plotting" page instead?

Anyways, I'm happy to trust your judgment here. I'm happy to merge now and iterate later.

(Also, I'm not a huge fan of the prominent "Download all" links, they seem mostly like clutter to me -- but that's a side note.)

@fmaussion
Copy link
Member Author

I agree with you @shoyer , but it can still provides a little bit more than mere plotting examples.

How about naming the gallery "Recipes" and keep it in the examples section for now?

@shoyer
Copy link
Member

shoyer commented May 23, 2017

How about naming the gallery "Recipes" and keep it in the examples section for now?

Sounds good to me.

@fmaussion fmaussion merged commit f7eb309 into master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants