Make flake8 xarray pass
#1824
Merged
Make flake8 xarray pass
#1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
auto-flake
branch
2 times, most recently
from
536b48f to
9c9a72e
Compare
shoyer
reviewed
Jan 14, 2018
xarray/tests/test_backends.py
Outdated
| print(ds2.randovar.values) # should raise IndexError in netCDF4 | ||
| except IndexError as err: | ||
| self.assertIn('first by calling .load', str(err)) | ||
| with pytest.raises(IndexError) as err: |
There was a problem hiding this comment.
This modified test is failing in Travis. I think we actually want to keep something similar to what we had before. The idea was that netcdf4 was raising an error that we wanted to be sure we were reraising with a better error message. NetCDF4 stopped raising the error in recent versions,so we can silently ignore this behavior if a newer version of netcdf4 is installed.
There was a problem hiding this comment.
Makes sense - I'll improve the comment instead 😆
| @@ -27,7 +27,7 @@ def set_to_zero(self, x, i): | |||
| def test_expanded_indexer(self): | |||
| x = np.random.randn(10, 11, 12, 13, 14) | |||
| y = np.arange(5) | |||
| I = ReturnItem() | |||
| I = ReturnItem() # noqa: E741 # allow ambiguous name | |||
There was a problem hiding this comment.
These meaningless noqa numbers are one reason why I like pylint over flake8 sometimes...
|
@shoyer; done 🎉 |
jhamman
approved these changes
Jan 14, 2018
|
Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1741 by @mrocklin (who did most of the work I'm presenting here). I had an evening free, so I rebased the previous pull on master, fixed the conflicts, and then made everything pass with
flake8's default settings (including line length). My condolences to whoever gets to review this diff!The single change any non-pedant will notice: Travis now fails if there is a flake8 warning anywhere. My experience in other projects is that this is the only way to actually keep flake8 passing - it's just unrealistic to expect perfect attention to detail from every contributor, but "make the build green before we merge" is widely understood 😄