-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Tweak stickler config: ignore Python files in the docs & disable fixer #1936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/gallery/plot_lines_from_2d.py
Outdated
@@ -15,6 +15,11 @@ | |||
import xarray as xr | |||
import matplotlib.pyplot as plt | |||
|
|||
|
|||
def badly(spaced): | |||
1 + 1/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W1619 division w/o future statement
doc/gallery/plot_lines_from_2d.py
Outdated
@@ -15,6 +15,11 @@ | |||
import xarray as xr | |||
import matplotlib.pyplot as plt | |||
|
|||
|
|||
def badly(spaced): | |||
1 + 1 / 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W1619 division w/o future statement
Maybe we should turn off the fixer also? |
I would like to disable the fixer (which appears to use autopep8) entirely, for several reasons:
|
I'm not sure if you were suggesting turning it off entirely or only for the docs... but as I wrote above, I don't like it either. |
16ebdf6
to
6150fd9
Compare
Yes, totally, stickler should NOT try to fix anything. Would you like to turn off stickler entirely or just the auto-fixer? I'm fine with both: while I thinks it's nice to have a tool pointing out pep8 errors (I don't like to do it as a reviewer, it makes me feel like nit-picking), I also find it quite noisy and not very encouraging to submit PRs at an early "quick n dirty" stage, where you really shouldn't care about pep8... |
I agree, but the alternative is to get a failed build error, and it can be a pain to dig through the Travis-CI to find out what went wrong. We use automated comments like this at work to enforce style, and on the whole I think they're probably a good thing. I would certainly encourage contributors not to worry about these errors until they think their code is ready to submit. |
It doesn't always make sense to lint these files fully.