Skip to content

docstrings for isnull and notnull #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 30, 2020
Merged

docstrings for isnull and notnull #4618

merged 6 commits into from
Nov 30, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Nov 29, 2020 •
edited
Loading

As suggested in #2760 this moves isnull and notnull to DataWithCoords. The body is adapted from DataWithCoords.isin, but I'm not certain dask="allowed" is the right option for duck_array_ops.isnull. Can someone with more experience with apply_ufunc confirm?

  • Closes docs clarity for notnull() etc #2760
  • Tests added
  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@max-sixty max-sixty mentioned this pull request Nov 29, 2020
Closed
3 tasks
shoyer
shoyer approved these changes Nov 30, 2020
View reviewed changes
@keewis keewis mentioned this pull request Nov 30, 2020
Closed
3 tasks
@dcherian dcherian merged commit 255bc8e into pydata:master Nov 30, 2020
@keewis keewis deleted the isnull-docstring branch November 30, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs clarity for notnull() etc
3 participants
@keewis @shoyer @dcherian