-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI: run mypy in full env #4929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: run mypy in full env #4929
Conversation
the workflow looks good to me, but it should probably be possible to skip it using Edit: since it will always fail right now, should we disable this workflow for now and you enable it in #4878? |
Co-authored-by: keewis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Before merging, I think we should disable the CI for now, though, please enable it in #4878
Thanks, @mathause, looks good to me. I wonder if we should move this into |
Thanks - just for reference - this is currently unconditionally inactive & should be activated in #4878 |
pre-commit run --all-files
whats-new.rst
I only added one run for py3.8 latest. To be entirely sure we could also check the typing
py37-min-all-deps
but it feels like overkill...Ok, looks good - the failure is expected - see #4878.