Skip to content

remove deprecations scheduled for 0.19 #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 23, 2021
Merged

remove deprecations scheduled for 0.19 #5630

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8aacaf5
remove the deprecated dim kwarg for DataArray.integrate
keewis Jul 22, 2021
dda0280
remove the deprecated keep_attrs kwarg to .rolling
keewis Jul 22, 2021
986b8fd
remove the keep_attrs kwarg to .coarsen
keewis Jul 22, 2021
c6b33e6
raise a TypeError when passing DataArray to Variable
keewis Jul 22, 2021
5cc85c8
remove the deprecated return value of Dataset.update
keewis Jul 22, 2021
85f5d2c
remove the outdated datasets argument to combine_by_coords
TomNicholas Jul 23, 2021
a1d576d
fixed linting for combine_by_coords deprecation
TomNicholas Jul 23, 2021
c245cac
all deprecations in the what's new
TomNicholas Jul 23, 2021
6599955
remove the documentation pages for the removed attributes [skip-ci]
keewis Jul 23, 2021
132a8b8
Undo the deprecation and schedule the removal for 0.21
keewis Jul 23, 2021
2d0ef4c
update whats-new.rst
keewis Jul 23, 2021
efc82d3
point to Dataset.merge [skip-ci]
keewis Jul 23, 2021
b4252cc
Undo the removal of the update return value and update the scheduled …
keewis Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions xarray/core/combine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,16 +635,14 @@ def _combine_single_variable_hypercube(
return concatenated


# TODO remove empty list default param after version 0.19, see PR4696
def combine_by_coords(
data_objects=[],
data_objects,
compat="no_conflicts",
data_vars="all",
coords="different",
fill_value=dtypes.NA,
join="outer",
combine_attrs="no_conflicts",
datasets=None,
):
"""
Attempt to auto-magically combine the given datasets (or data arrays)
Expand Down Expand Up @@ -849,14 +847,6 @@ def combine_by_coords(
precipitation (y, x) float64 0.4376 0.8918 0.9637 ... 0.5684 0.01879 0.6176
"""

# TODO remove after version 0.19, see PR4696
if datasets is not None:
warnings.warn(
"The datasets argument has been renamed to `data_objects`."
" In future passing a value for datasets will raise an error."
)
data_objects = datasets

if not data_objects:
return Dataset()

Expand Down