Skip to content

Fix dataarray determination in map_blocks #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 29, 2021
Merged

Fix dataarray determination in map_blocks #6089

merged 7 commits into from
Dec 29, 2021

Conversation

tcchiao
Copy link
Contributor

@tcchiao tcchiao commented Dec 21, 2021 •
edited
Loading

@max-sixty
Copy link
Collaborator

Thanks @tcchiao !

@dcherian you know this better than me — want to hit the button?

@max-sixty max-sixty requested a review from dcherian December 21, 2021 07:34
@tcchiao
Copy link
Contributor Author

tcchiao commented Dec 22, 2021

thanks @max-sixty! @dcherian a review would be great -- I don't believe the changes are causing the test failures, but am also not sure of the root cause. Please let me know if you see anything in this PR that will help with the tests (and any other comments of course), thank you!

@keewis
Copy link
Collaborator

keewis commented Dec 22, 2021

can you merge in the most recent state of main? With that the internal errors should disappear, revealing the actual errors (if any).

@dcherian
Copy link
Contributor

Thanks @tcchiao This LGTM! Please add a note in whats-new.rst if you'd like.

@Illviljan Illviljan added the plan to merge Final call for comments label Dec 29, 2021
Illviljan and others added 3 commits December 29, 2021 12:45
@Illviljan
Merge branch 'main' into pr/6089
63b4602
@dcherian
Merge branch 'main' into mapblock-fix
a0f67d8 
* main:
  Replace markdown issue templates with issue forms (pydata#6119)
  Remove lock kwarg (pydata#5912)
  Remove pre-commit GHA workflow (pydata#6120)
  is_dask_collection: micro optimization (pydata#6107)
@dcherian
[skip-ci] add whats-new
8252a9c
@dcherian
Copy link
Contributor

Thanks @tcchiao this is a great first PR. Welcome to xarray!

@dcherian dcherian merged commit f85ec66 into pydata:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map_blocks not converting dataarrays correctly
5 participants
@tcchiao @max-sixty @keewis @dcherian @Illviljan