-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove registration of pandas datetime converter in plotting #6109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
282e28d
remove datetime converters
Illviljan 2079981
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 828a4f7
Merge branch 'main' into remove_mpl_registration
Illviljan 7ba7307
Update utils.py
Illviljan 22b928d
Merge branch 'main' into remove_mpl_registration
Illviljan add7086
Update whats-new.rst
Illviljan 3890d09
add a todo comment
Illviljan 9a7c09c
Merge branch 'main' into remove_mpl_registration
Illviljan d4f15aa
Merge branch 'main' into remove_mpl_registration
Illviljan a00d506
Update whats-new.rst
Illviljan e63cdea
Merge branch 'main' into remove_mpl_registration
Illviljan 9da14c9
Add tests
Illviljan 5b772fb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5842964
Apply suggestions from code review
Illviljan 228e0be
Update test_plot.py
Illviljan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,20 +28,9 @@ | |
ROBUST_PERCENTILE = 2.0 | ||
|
||
|
||
_registered = False | ||
|
||
|
||
def register_pandas_datetime_converter_if_needed(): | ||
# based on https://github.com/pandas-dev/pandas/pull/17710 | ||
global _registered | ||
if not _registered: | ||
pd.plotting.register_matplotlib_converters() | ||
_registered = True | ||
|
||
|
||
def import_matplotlib_pyplot(): | ||
"""Import pyplot as register appropriate converters.""" | ||
Illviljan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
register_pandas_datetime_converter_if_needed() | ||
# TODO: This function doesn't do anything, remove it? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function doesn't do much anymore without the registration. It can probably be removed later once this PR has been tested a bit in the field.
Illviljan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import matplotlib.pyplot as plt | ||
|
||
return plt | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.