-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
MNT: prepare h5netcdf backend for (coming) change in dimension handling #6200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kmuehlbauer
commented
Jan 27, 2022
- Closes ⚠️ Nightly upstream-dev CI failed ⚠️ #6197
@mathause Although I'm pretty sure that this fixes the upstream-dev run, it would be good to verify. Is it possible to run the upstream-dev with this PR? |
I'd also like to add fixes to silence new FutureWarnings emitted by |
Great! Thanks for the fix. Yes the string |
Could you please have a look at the chunksizes FutureWarnings (eg. here https://github.com/pydata/xarray/runs/4965336696?check_suite_focus=true#step:8:344). Are the chunksizes via |
@mathause The fix is applied and works. We have some issues with |
Looks good. The remaining upstream failure does not seem to be related. |
Let's take this in h5netcdf/h5netcdf#149. |
Thanks @kmuehlbauer! |
|
Sorry I was wrong - this was not the cause for the test failure. Let's keep this as is. |