GHA concurrency
#6210
GHA concurrency
#6210
Conversation
|
Lgtm! Thanks @aaronspring |
There was a problem hiding this comment.
This looks great, @aaronspring! It's my understanding that the concurrency ensures that there are no duplicate jobs for the same ref. I was wondering if we still need the skip-duplicate-jobs as part of the CI?
|
In my understanding we can get rid of fkirc/skip-duplicate-actions and cancel-duplicate-runs.yaml |
| if: | | ||
| github.repository == 'pydata/xarray' | ||
| && (github.event_name == 'push' || github.event_name == 'pull_request') |
There was a problem hiding this comment.
@aaronspring, we may want to keep this condition so as to avoid running the CI on forks
There was a problem hiding this comment.
Shouldn’t we keep this? @max-sixty @andersy005
There was a problem hiding this comment.
we should! @aaronspring, can you open a new PR for that?
There was a problem hiding this comment.
Sorry, I merged too early. @aaronspring if you can open a PR then great, otherwise I can as penance
There was a problem hiding this comment.
I put the condition in detect-ci-trigger in #6223
|
Great — merging, thanks @aaronspring ! |
whats-new.rstapi.rsthttps://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
concurrencyinstead ofcancel-duplicate-runs.yaml