-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Run pyupgrade on core/utils #6240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Doc failure seems unrelated. |
I've seen this a couple of times. I thought I added it so it happened automatically. Does it not? |
Thanks a lot @Illviljan ! (I don't think you need to wait for a review for these. Or lmk if you think we should and I will change my behavior :) ) |
Ok I'll merge. I was mostly waiting a little so a few could see the comments because I thought pyupgrade would just do the typing upgrade automagically, but it requires adding |
I think this happens when pre-commit finds errors the 2nd time after it has already done a commit. |
Make #6239 cleaner by running pyupgrade separately.
pyupgrade fixes typing only if
from __future__ import annotations
has been manually added to the file. Could probably do this in other files as well.xref: #6244