Skip to content

Remove some warnings in tests #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Remove some warnings in tests #6986

merged 4 commits into from
Sep 5, 2022

Conversation

headtr1ck
Copy link
Collaborator

This PR tries to get rid of several warnings in the tests.

I could not get rid of RuntimeWarning: All-NaN slice encountered for tests with dask.
Does anyone know why is that? pytest.mark.filterwarnings does not seem to capture them...

@mathause
Copy link
Collaborator

mathause commented Sep 5, 2022

I could not get rid of RuntimeWarning: All-NaN slice encountered for tests with dask. Does anyone know why is that? pytest.mark.filterwarnings does not seem to capture them...

Yes, because we remove them in our assert* checks. Would be fixed with #6212 using somewhat non-public API. We should probably do it anyway...

@headtr1ck
Copy link
Collaborator Author

Should we filter deprecation warnings from external libraries like pydap or netCDF4 at a global level?

Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Should we filter deprecation warnings from external libraries like pydap or netCDF4 at a global level?

It generates noise but it also let's us see (and potentially report or fix) upstream issues. So I prefer to leave them on.

@max-sixty
Copy link
Collaborator

Thanks a lot @headtr1ck !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants