Add helper for setting axis limits in facetgrid #7046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathause
approved these changes
Sep 22, 2022
xarray/plot/facetgrid.py
Outdated
Comment on lines
494
to
502
| # Find the plot with the largest xlim values: | ||
| for ax in self.axes.flat: | ||
| get_lim: None | Callable[[], tuple[float, float]] = getattr( | ||
| ax, f"get_{k}lim", None | ||
| ) | ||
| if get_lim: | ||
| l0, l1 = get_lim() | ||
| l0_old, l1_old = lims_largest[k] | ||
| lims_largest[k] = (min(l0, l0_old), max(l1, l1_old)) |
There was a problem hiding this comment.
You could potentially avoid some dict lookups and only assign them at the end - but I don't think it really matters.
There was a problem hiding this comment.
Hmm, I'm not seeing what you're seeing. Feel free to push a commit if you like.
mathause
reviewed
Sep 23, 2022
Co-authored-by: Mathias Hauser <[email protected]>
|
Thanks @mathause! I'll merge this in a few days. |
|
You don't need to specify |
keewis
reviewed
Sep 26, 2022
|
To be continued in #7082. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper method that sets the same axis limits for all plots in a facetgrid.
Helpful when
Split up from #6778.