-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix some typing errors in DuckArrayModule #7296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but also no idea why CI didn't catch this. For me locally this was also not catched...
Not sure what is up with minimum version policy and flox but it is unrelated. |
I think the CI wasn't catching this because of: Lines 73 to 77 in 63a69fe
|
Since now it seems to work, should we remove the ignore in It seems that this module does mostly handle lazy duck module imports and not python version fixes. |
Yeah, sounds reasonable. Maybe the reason for the ignore disappeared once DuckArrayModule was implemented? |
Fixes these errors that I've been seeing locally for a while:
Not sure why the CI isn't catching these?