Display data returned in apply_ufunc error message
#8179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes debugging much easier!
max-sixty
commented
Sep 13, 2023
xarray/core/computation.py
Outdated
| f"number of dimensions. Received {data.ndim} dimension(s) but " | ||
| f"expected {len(dims)} dimensions with names: {dims!r}" | ||
| f"expected {len(dims)} dimensions with names: {dims!r}. The data returned " | ||
| f"was:\n\n{data!r}" |
There was a problem hiding this comment.
Another option would to log this sort of info. It's not a "full report" of the error, since there might be other datas.
(I would vote to merge and then change in the future if it turns out to be confusing, but if someone has a different view I'm v happy to make changes)
Illviljan
reviewed
Sep 13, 2023
for more information, see https://pre-commit.ci
max-sixty
changed the title
apply_ufunc error message
headtr1ck
approved these changes
Sep 14, 2023
dcherian
reviewed
Sep 15, 2023
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Sep 15, 2023
Based on the correct observation in pydata#8179 (comment) (slightly adjusted message)
max-sixty
added a commit
that referenced
this pull request
Sep 17, 2023
* Adjust ufunc error message Based on the correct observation in #8179 (comment) (slightly adjusted message) * Update xarray/core/computation.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/core/computation.py --------- Co-authored-by: Deepak Cherian <[email protected]>
max-sixty
added a commit
to max-sixty/xarray
that referenced
this pull request
Sep 17, 2023
* Adjust ufunc error message Based on the correct observation in pydata#8179 (comment) (slightly adjusted message) * Update xarray/core/computation.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/core/computation.py --------- Co-authored-by: Deepak Cherian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes debugging much easier!