Skip to content

Set CONDA_PREFIX to make is useable in conda activate/deactivate scripts #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

cpaulik
Copy link
Contributor

@cpaulik cpaulik commented Jul 19, 2017

The CONDA_PREFIX environment variable is used in some activate/deactivate scripts. If it is not set they do not work correctly. One example is the gdal package.

The CONDA_PREFIX variable is normally set in activate which is not used in pyenv.

@yyuu
Copy link
Collaborator

yyuu commented Jul 20, 2017

Looks good 👍 Could you try updating tests too when you get a chance?

@cpaulik cpaulik force-pushed the support-conda-prefix branch from 905bbce to f64c8ed Compare July 20, 2017 13:54
@cpaulik
Copy link
Contributor Author

cpaulik commented Jul 20, 2017

I've updated the tests, hopefully correctly.

@yyuu
Copy link
Collaborator

yyuu commented Jul 21, 2017

Great! Thanks you

@yyuu yyuu merged commit 2727087 into pyenv:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants