Skip to content

Update odsw.py #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Update odsw.py #28

merged 2 commits into from
Oct 1, 2021

Conversation

vinraspa
Copy link
Contributor

Add datetime.datetime support to pyexcel_ods3.odsw.ODSSheetWriter.write_row(array) method.
To be usable, this patch requires first that a pull request is accepted by pyexcel_io maintainers (datetime.datetime: "datetime" key:value pair must be added to ODS_WRITE_FORMAT_COVERSION dictionary..
Thank you

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

Add 'datetime' support to pyexcel_ods3.odsw.ODSSheetWriter.write_row(array)
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #28 (ad14702) into dev (c4f8805) will decrease coverage by 0.31%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #28      +/-   ##
==========================================
- Coverage   98.70%   98.38%   -0.32%     
==========================================
  Files          12       12              
  Lines         618      621       +3     
==========================================
+ Hits          610      611       +1     
- Misses          8       10       +2     
Impacted Files Coverage Δ
pyexcel_ods3/odsw.py 96.49% <33.33%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f8805...ad14702. Read the comment docs.

@chfw chfw merged commit 0df1eb7 into pyexcel:dev Oct 1, 2021
@chfw chfw mentioned this pull request Oct 8, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants