Add new If guard helper methods #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is technically a new feature, should it go in |
This was referenced Jul 13, 2021
|
This is useful enough that I want it asap in pylint but it's true it's a new feature. I would not mind having it in 2.6.3 though. |
|
I think it would force us to release astroid 2.7.0 very fast, so we can put pylint-dev/pylint#4702 in pylint 2.10. |
|
Moving this to 2.6.3 and merging because we need it for pylint-dev/pylint#4703 that is in pylint 2.9.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
If.is_sys_guardandIf.is_typing_guardhelper methods. Most useful to check if analysis of theifbody should be skipped, e.g. because module are not available for the checked python version.Type of Changes
Related Issue
pylint-dev/pylint#4702
pylint-dev/pylint#4703