Skip to content

Upgrade mypy to 0.930 #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Upgrade mypy to 0.930 #1310

merged 1 commit into from
Dec 23, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Dec 23, 2021

@cdce8p cdce8p added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Dec 23, 2021
@cdce8p cdce8p added this to the 2.9.1 milestone Dec 23, 2021
@cdce8p cdce8p marked this pull request as ready for review December 23, 2021 12:44
@cdce8p
Copy link
Member Author

cdce8p commented Dec 23, 2021

The failure is caused by Python 3.10.1, not the mypy upgrade. Needs to be fixed separately.

@cdce8p cdce8p merged commit 3059613 into pylint-dev:main Dec 23, 2021
@cdce8p cdce8p deleted the upgrade-mypy branch December 23, 2021 12:46
@DanielNoord
Copy link
Collaborator

We postponed updating tbump in pylint because of that fail, see pylint-dev/pylint#5572

@cdce8p
Copy link
Member Author

cdce8p commented Dec 23, 2021

We postponed updating tbump in pylint because of that fail, see PyCQA/pylint#5572

@DanielNoord Are you sure those are related? The issue here looks like one with Python 3.10.1 on Windows.
https://github.com/PyCQA/astroid/runs/4618100769?check_suite_focus=true#step:7:70

@DanielNoord
Copy link
Collaborator

Oh my bad! Didn't read the traceback fully. I saw distutils and assumed they were related. Seems like a strange coincidence then.

tushar-deepsource pushed a commit to tushar-deepsource/astroid that referenced this pull request Dec 24, 2021
@DanielNoord
Copy link
Collaborator

@cdce8p Are you looking into this failure or should somebody else do this? It's affecting tests of other PRs as well so we should probably try and fix this asap.

@cdce8p
Copy link
Member Author

cdce8p commented Dec 24, 2021

@cdce8p Are you looking into this failure or should somebody else do this? It's affecting tests of other PRs as well so we should probably try and fix this asap.

@DanielNoord I didn't had time for it yet. Do you by chance use Windows? I think that would definitely help when debugging it. I'm on macOS unfortunately for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants