-
-
Notifications
You must be signed in to change notification settings - Fork 292
Change site packages look up to use sysconfig instead of distutils #1322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't looked at it yet. Just one comment about the timeline. I would suggest / prefer to put this into |
Okay! I have added it as the milestone to all PRs. |
We could also create a 2.9.2 release, there's almost 50 issues in 2.9.1, it's a lot for astroid. (Especially since the fix to symlinks is a much awaited bug fix). I released 2.9.1, I'll let you judge if 2.9.2 is necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Small step toward removing distutils, great !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @DanielNoord!
I'll review the others too, but we could start with merging this one.
Steps
Description
While is was reading up on
distutils
etc I thought I would try and see if we can remove all calls to it.There are three calls to
distutils
, which should all be done in separate PRs because of the complexity and risk of errors. If you agree I think we should try and put them in2.9.1
as well (I know, another delay) so we can combine all fixes to the YOLO-option and removal ofdistutils
at the same time. (YOLO-option from #1321, that is.)For the change in this PR:
get_python_lib
returns the directory ofsite-packages
. "Return the directory for either the general or platform-dependent library installation. If plat_specific is true, the platform-dependent include directory is returned; if false or omitted, the platform-independent directory is returned."This functionality is "replaced" by
sysconfig.get_path
. By using bothpurelib
andplatlib
we got both of them again.Type of Changes
Related Issue