Fix ImportedModuleTests #1552
Merged
Fix ImportedModuleTests #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
May 12, 2022
jacobtylerwalls
added
the
Maintenance
Pull Request Test Coverage Report for Build 2316558741
💛 - Coveralls |
jacobtylerwalls
commented
May 12, 2022
There was a problem hiding this comment.
I could conform these to the way Marc did them in #1553, but I think it harms readability.
jacobtylerwalls
force-pushed
the
fix-import-tests
branch
from
152b4ca to
4883d5c
Compare
jacobtylerwalls
force-pushed
the
fix-import-tests
branch
from
4883d5c to
92e312c
Compare
Pierre-Sassoulas
approved these changes
May 13, 2022
cdce8p
reviewed
May 13, 2022
| @@ -6628,38 +6628,60 @@ def test_inference_of_items_on_module_dict() -> None: | |||
| builder.file_build(str(DATA_DIR / "module_dict_items_call" / "test.py"), "models") | |||
|
|
|||
|
|
|||
| class ImportedModuleTests(resources.AstroidCacheSetupMixin): | |||
There was a problem hiding this comment.
Just a note, you don't need to remove test classes. Even with pytest, they can be helpful to group test cases. I believe the only important things to remember are the classname must begin with Test... and you can use @staticmethod if you don't need self.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Changes
Related Issue
Follow-up to #1399. This needed to subclass
TestCaseto actually run, and that revealed that clearing the cache before each test method was necessary. cc @tristanlatr EDIT: er, better to use new module names, and avoid clearing the cache altogether, since that's not what's being tested.